Make it harder to overwrite published, Production apps #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelGoberling
requested review from
shazron,
purplecabbage,
moritzraho,
amulyakashyap09 and
arjuncooliitr
|
@MichaelGoberling code conflict reported, can you resolve so the tests run? |
moritzraho
reviewed
Jul 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2619 2629 +10
Branches 476 478 +2
=========================================
+ Hits 2619 2629 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
moritzraho
reviewed
Jul 19, 2022
|
Update: We are still looking over semantics to make sure the --force-deploy flag makes sense. Discussion and final decision needed before merging. |
|
I can't think of a better syntax for triggering this functionality so I will lets move forward with this. |
|
This caused a bug: #587 (am fixing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes checking the Extension Registry API to see if an App Builder application is in a published state before attempting to deploy action code or web assets. It also proposes adding a flag which will bypass this check and allow users to deploy code for published Production applications.
Description
These changes implement the new Console API and Extension Registry API changes introduced here so that we can determine if an App Builder application is in a published state or not.
The
getProjectfunction was needed from the Console API so that we can fetch theappIdfor the project that is stored in the Extension Registry.A new flag
force-deployhas been added as a part of this pull request for thedeploycommand that bypasses this check.Related Issue
Motivation and Context
To make it more difficult to overwrite published Production App Builder applications.
How Has This Been Tested?
Tested locally with
npm run testand linked version ofaio-cli-lib-consoleandaio-lib-console.Screenshots (if appropriate):
Types of changes
Checklist: